update the jaeger-client dependency to the latest #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwatson
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
jkwatson
commented
Apr 21, 2021
| thriftSender = new HttpSender.Builder(endpoint).build(); | ||
| try { | ||
| thriftSender = new HttpSender.Builder(endpoint).build(); | ||
| } catch (TTransportException e) { |
There was a problem hiding this comment.
this was an unfortunate breaking change in the library's APIs. :(
anuraaga
approved these changes
Apr 22, 2021
Only that I saw that jaeger was updated for a security vulnerability in lib-thrift and it might be good to make sure we were upgraded, even though the vulnerability only impacted the server side of jaeger. We should surely upgrade other deps as well. |
This was referenced Dec 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.