inject alpha into the version for metrics api and sdk. #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2311 +/- ##
============================================
- Coverage 87.72% 87.71% -0.02%
- Complexity 2429 2430 +1
============================================
Files 270 270
Lines 8163 8163
Branches 906 906
============================================
- Hits 7161 7160 -1
- Misses 671 672 +1
Partials 331 331
Continue to review full report at Codecov.
|
jkwatson
approved these changes
Dec 16, 2020
anuraaga
reviewed
Dec 16, 2020
| @@ -6,6 +6,10 @@ plugins { | |||
| id "ru.vyarus.animalsniffer" | |||
| } | |||
|
|
|||
| version = "${version}".replaceFirst(/^(\d+)\.(\d+).(\d+)/) { _, major, minor, patch -> | |||
There was a problem hiding this comment.
I've stared a lot but don't think I'm missing it - isn't this just version += '-alpha'?
There was a problem hiding this comment.
not with -SNAPSHOT versions, where -alpha needs to be inserted in the middle.
anuraaga
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2266.
After doing a
./gradlew clean buildthe jars with alpha look like: