Use the concise license header without the year #1623
Conversation
dengliming
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
pavolloffay,
thisthat and
tylerbenson
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1623 +/- ##
============================================
+ Coverage 85.17% 85.55% +0.37%
- Complexity 1369 1372 +3
============================================
Files 163 163
Lines 5317 5316 -1
Branches 554 554
============================================
+ Hits 4529 4548 +19
+ Misses 586 567 -19
+ Partials 202 201 -1
Continue to review full report at Codecov.
|
|
@bogdandrutu or @carlosalberto is this an acceptable license header? I think it's great, but I don't want to have to revert this if it's not ok with the TC. :) |
|
@jkwatson I saw in other repos using the header without the year but the license text was still there. |
|
Although Yuri also states the two lines license as a valid option, most OTel Projects use the format @bogdandrutu mentioned. (Maybe it's a good time to finally settle the related discussion in Community) |
|
If we can get sign-off on this being the preferred header, it's definitely the most concise and light-weight. |
|
@jkwatson pushing on that issue to be closed open-telemetry/community#113 (comment) |
|
@dengliming Sorry for the delay on this! I see the community repo was updated with guidance that allows the short header. Would you be able to merge master and reapply this change? Thanks a lot for the patience. |
…year # Conflicts: # api/src/main/java/io/opentelemetry/common/AttributeValue.java # api/src/main/java/io/opentelemetry/common/ReadableKeyValuePairs.java # api/src/main/java/io/opentelemetry/correlationcontext/CorrelationContextManager.java # api/src/main/java/io/opentelemetry/correlationcontext/CorrelationsContextUtils.java # api/src/main/java/io/opentelemetry/correlationcontext/DefaultCorrelationContextManager.java # api/src/main/java/io/opentelemetry/trace/attributes/BooleanAttributeSetter.java # api/src/main/java/io/opentelemetry/trace/attributes/DoubleAttributeSetter.java # api/src/main/java/io/opentelemetry/trace/attributes/LongAttributeSetter.java # api/src/main/java/io/opentelemetry/trace/attributes/StringAttributeSetter.java # api/src/test/java/io/opentelemetry/common/AttributeValueTest.java # api/src/test/java/io/opentelemetry/correlationcontext/CorrelationsContextUtilsTest.java # api/src/test/java/io/opentelemetry/trace/attributes/BooleanAttributeSetterTest.java # api/src/test/java/io/opentelemetry/trace/attributes/DoubleAttributeSetterTest.java # api/src/test/java/io/opentelemetry/trace/attributes/LongAttributeSetterTest.java # api/src/test/java/io/opentelemetry/trace/attributes/SemanticAttributesTest.java # api/src/test/java/io/opentelemetry/trace/attributes/StringAttributeSetterTest.java # sdk/correlation_context/src/main/java/io/opentelemetry/sdk/correlationcontext/CorrelationContextManagerSdk.java # sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/data/MetricDataDescriptorTest.java # sdk/tracing/src/main/java/io/opentelemetry/sdk/trace/TimedEvent.java # sdk/tracing/src/test/java/io/opentelemetry/sdk/trace/TimedEventTest.java # sdk_extensions/logging/src/main/java/io/opentelemetry/sdk/logging/LogProcessor.java
|
@anuraaga Thanks. reapply now. |
|
Thanks so much! |
closes #1212