Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples from the latest updates. #1495

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

jkwatson
Copy link
Contributor

@jkwatson jkwatson commented Aug 3, 2020

looks like sampling changes didn't make it into the examples. And, some grpc issues with building the grpc examples.

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #1495 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1495   +/-   ##
=========================================
  Coverage     92.50%   92.50%           
  Complexity      938      938           
=========================================
  Files           117      117           
  Lines          3348     3348           
  Branches        270      270           
=========================================
  Hits           3097     3097           
  Misses          170      170           
  Partials         81       81           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dffbb8...670640c. Read the comment docs.

@carlosalberto carlosalberto merged commit 4680c3a into open-telemetry:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants