-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging sink api #1421
Logging sink api #1421
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1421 +/- ##
============================================
- Coverage 92.11% 91.97% -0.14%
- Complexity 904 930 +26
============================================
Files 115 120 +5
Lines 3258 3391 +133
Branches 265 266 +1
============================================
+ Hits 3001 3119 +118
- Misses 173 187 +14
- Partials 84 85 +1
Continue to review full report at Codecov.
|
* @since 0.7.0 | ||
*/ | ||
@Immutable | ||
public abstract class AnyValue { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have a proto version of this class already. is there a reason we can't use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely have it in opentelemetry-proto, but I believe that api does not have a dependency on proto. I could be wrong- I'm trying to mirror how we are doing it with AttributeValue
.
If this isn't meant to be a user-level logging API, why have it accessible as a user-level instrumentation API? Users will definitely be confused if it's there, but they aren't supposed to use it. |
It's not that it can't be used as a logging API, but it's not going to be ergonomic. This is to enable adapters for existing logging libraries to output through OpenTelemetry. It would also be the foundation for an ergonomic logging library, but I think that's going to be easier to work through when we have functional plumbing. |
I don't think we should add a logging API until it has made it into the official specifications. Especially before GA. I believe the agreement is that we will not GA with a logging API. Please point me somewhere else if I am wrong about that. |
@zenmoto to make progress, would strongly suggest to start in one of the extensions directories. |
Thank you @bogdandrutu - I'll close this and take that approach instead. |
This is an attempt at an initial log delivery API. It's not targeted as a replacement for a user-level logging API, instead it's focused on taking log entries and passing them on to an SDK for processing and delivery. The model is based off of open-telemetry/opentelemetry-proto#151.