Add error tag to spans for Jaeger exporter #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auto-instrumentation libraries add errors to the spans when they occur. The error tag is not added to the spans by the Jaeger exporter if the span status is not OK. When sending these spans to the OpenTelemetry Collector it will add the error tag when it translates them and sends them to the Jaeger collector. This process does not take place when sending spans directly to a Jaeger collector (not using the OTel collector) and so the Jaeger UI does not display visual indicators for spans with errors. Adding the error tag in the adapter if the span.status.code is not OK, and this tag hasn't already been set, means that it will be present when using either the OTel collector or the Jaeger collector directly. The Otel collector will remove this tag automatically when it receives the span and sets the status code so this will not be sent as a duplicate.
sleighzy
requested review from
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
pavolloffay,
songy23 and
tylerbenson
as code owners
jkwatson
approved these changes
Apr 25, 2020
trask
reviewed
Apr 25, 2020
exporters/jaeger/src/main/java/io/opentelemetry/exporters/jaeger/Adapter.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: Trask Stalnaker <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1141 +/- ##
=========================================
Coverage 85.09% 85.10%
- Complexity 1120 1121 +1
=========================================
Files 144 144
Lines 4254 4256 +2
Branches 384 385 +1
=========================================
+ Hits 3620 3622 +2
Misses 484 484
Partials 150 150
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto-instrumentation libraries add errors to the spans when they occur. The
errortag is not added to the spans by the Jaeger exporter if the span status code is notOK.When sending these spans to the OpenTelemetry Collector it will automatically add the
errortag when it translates them, based on the status code, and sends them to the Jaeger collector.This process does not take place when sending spans directly to a Jaeger collector (not using the OTel collector) and so the Jaeger UI does not display visual indicators for spans with errors.
By adding the
errortag in the Adapter class if the span.status.code is notOK, if this tag hasn't already been added, means that it will be present when using either the OTel collectoror the Jaeger collector directly. The Otel collector will remove this tag automatically when it receives the span and sets the status code so this will not be sent as a duplicate.
Fixes #1139