Remove ComponentRegistry#get(String) overload

This overload is not no longer used by our code.
open-telemetry · Nov 1, 2020 · db56814 · db56814
1 parent 4b28eaf
commit db56814
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 19 deletions.
diff --git a/sdk/common/src/main/java/io/opentelemetry/sdk/internal/ComponentRegistry.java b/sdk/common/src/main/java/io/opentelemetry/sdk/internal/ComponentRegistry.java
@@ -22,18 +22,6 @@ public abstract class ComponentRegistry<V> {
 
   private final ConcurrentMap<InstrumentationLibraryInfo, V> registry = new ConcurrentHashMap<>();
 
-  /**
-   * Returns the registered value associated with this name and {@code null} version if any,
-   * otherwise creates a new instance and associates it with the given name and {@code null}
-   * version.
-   *
-   * @param instrumentationName the name of the instrumentation library.
-   * @return the registered value associated with this name and {@code null} version.
-   */
-  public final V get(String instrumentationName) {
-    return get(instrumentationName, null);
-  }
-
   /**
    * Returns the registered value associated with this name and version if any, otherwise creates a
    * new instance and associates it with the given name and version.

diff --git a/sdk/common/src/test/java/io/opentelemetry/sdk/internal/ComponentRegistryTest.java b/sdk/common/src/test/java/io/opentelemetry/sdk/internal/ComponentRegistryTest.java
@@ -37,13 +37,6 @@ void libraryVersion_AllowsNull() {
     assertThat(testComponent.instrumentationLibraryInfo.getVersion()).isNull();
   }
 
-  @Test
-  void getSameInstanceForSameName_WithoutVersion() {
-    assertThat(registry.get(INSTRUMENTATION_NAME)).isSameAs(registry.get(INSTRUMENTATION_NAME));
-    assertThat(registry.get(INSTRUMENTATION_NAME))
-        .isSameAs(registry.get(INSTRUMENTATION_NAME, null));
-  }
-
   @Test
   void getSameInstanceForSameName_WithVersion() {
     assertThat(registry.get(INSTRUMENTATION_NAME, INSTRUMENTATION_VERSION))