Immutable values for AttributeValue arrays

open-telemetry · Feb 28, 2020 · b3b4a3e · b3b4a3e
1 parent f31ec08
commit b3b4a3e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/api/src/main/java/io/opentelemetry/trace/AttributeValue.java b/api/src/main/java/io/opentelemetry/trace/AttributeValue.java
@@ -360,7 +360,7 @@ static AttributeValue create(boolean... booleanValues) {
       for (boolean value : booleanValues) {
         values.add(value);
       }
-      return new AutoValue_AttributeValue_AttributeValueBooleanArray(values);
+      return new AutoValue_AttributeValue_AttributeValueBooleanArray(Collections.unmodifiableList(values));
     }
 
     @Override
@@ -386,7 +386,7 @@ static AttributeValue create(long... longValues) {
       for (long value : longValues) {
         values.add(value);
       }
-      return new AutoValue_AttributeValue_AttributeValueLongArray(values);
+      return new AutoValue_AttributeValue_AttributeValueLongArray(Collections.unmodifiableList(values));
     }
 
     @Override
@@ -413,7 +413,7 @@ static AttributeValue create(double... doubleValues) {
       for (double value : doubleValues) {
         values.add(value);
       }
-      return new AutoValue_AttributeValue_AttributeValueDoubleArray(values);
+      return new AutoValue_AttributeValue_AttributeValueDoubleArray(Collections.unmodifiableList(values));
     }
 
     @Override