Fix flaky MetricExporterConfigurationTest (#5877)

open-telemetry · Oct 5, 2023 · 533c30a · 533c30a
1 parent c39ebfe
commit 533c30a
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/...stFullConfig/java/io/opentelemetry/sdk/autoconfigure/MetricExporterConfigurationTest.java b/...stFullConfig/java/io/opentelemetry/sdk/autoconfigure/MetricExporterConfigurationTest.java
@@ -34,8 +34,9 @@
 
 class MetricExporterConfigurationTest {
 
-  private static final ConfigProperties EMPTY =
-      DefaultConfigProperties.createFromMap(Collections.emptyMap());
+  private static final ConfigProperties CONFIG_PROPERTIES =
+      DefaultConfigProperties.createFromMap(
+          Collections.singletonMap("otel.exporter.prometheus.port", "0"));
 
   @RegisterExtension CleanupExtension cleanup = new CleanupExtension();
 
@@ -48,7 +49,7 @@ void configureReader_PrometheusOnClasspath() {
 
     MetricReader reader =
         MetricExporterConfiguration.configureReader(
-            "prometheus", EMPTY, spiHelper, (a, b) -> a, closeables);
+            "prometheus", CONFIG_PROPERTIES, spiHelper, (a, b) -> a, closeables);
     cleanup.addCloseables(closeables);
 
     assertThat(reader).isInstanceOf(PrometheusHttpServer.class);
@@ -60,7 +61,7 @@ void configureReader_PrometheusOnClasspath() {
   void configureExporter_KnownSpiExportersOnClasspath(
       String exporterName, Class<? extends Closeable> expectedExporter) {
     NamedSpiManager<MetricExporter> spiExportersManager =
-        MetricExporterConfiguration.metricExporterSpiManager(EMPTY, spiHelper);
+        MetricExporterConfiguration.metricExporterSpiManager(CONFIG_PROPERTIES, spiHelper);
 
     MetricExporter metricExporter =
         MetricExporterConfiguration.configureExporter(exporterName, spiExportersManager);
@@ -81,7 +82,7 @@ private static Stream<Arguments> knownExporters() {
   void configureMetricReader_KnownSpiExportersOnClasspath(
       String exporterName, Class<? extends Closeable> expectedExporter) {
     NamedSpiManager<MetricReader> spiMetricReadersManager =
-        MetricExporterConfiguration.metricReadersSpiManager(EMPTY, spiHelper);
+        MetricExporterConfiguration.metricReadersSpiManager(CONFIG_PROPERTIES, spiHelper);
 
     MetricReader metricReader =
         MetricExporterConfiguration.configureMetricReader(exporterName, spiMetricReadersManager);