Stable JVM semconv implementation: classes #9821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
laurit
approved these changes
Nov 14, 2023
jack-berg
approved these changes
Nov 14, 2023
...va8/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java8/Classes.java
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
jvm-stable-classes
branch
from
4bc3b43
to
eeb98ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started working on adding the stable JVM metrics to the agent (@jack-berg you mentioned you wanted to take a look at that too, hope I haven't conflicted with you), I added new values to the
otel.semconv-stability.opt-inconfig so that users can switch between versions in the same manner as HTTP semconv