Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use attributes advice for HTTP & RPC metrics #9440

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Use attributes advice for HTTP & RPC metrics #9440

merged 2 commits into from
Sep 13, 2023

Conversation

mateuszrzeszutek
Copy link
Member

Resolves #6819
Resolves #6209
Supersedes #7474

@mateuszrzeszutek mateuszrzeszutek requested a review from a team September 12, 2023 07:57
@mateuszrzeszutek mateuszrzeszutek added this to the v1.30.0 milestone Sep 12, 2023
trask
trask approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

...nv/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcMetricsAdvice.java Outdated Show resolved Hide resolved
@trask trask merged commit bbbc8dc into open-telemetry:main Sep 13, 2023
@mateuszrzeszutek mateuszrzeszutek deleted the attributes-advice branch September 13, 2023 17:30
@trask trask mentioned this pull request Oct 11, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.

How to modify view with HttpClientMetrics Add custom attribute through distro
3 participants
@mateuszrzeszutek @trask @laurit