Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require server.address and server.port in the HTTP client getter #9171

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Require server.address and server.port in the HTTP client getter #9171

merged 1 commit into from
Aug 9, 2023

Conversation

mateuszrzeszutek
Copy link
Member

These two are required by the spec, let's make them mandatory to implement

@mateuszrzeszutek mateuszrzeszutek requested a review from a team August 9, 2023 14:10
@trask trask enabled auto-merge (squash) August 9, 2023 14:55
@trask trask merged commit f8f8794 into open-telemetry:main Aug 9, 2023
breedx-splk pushed a commit to breedx-splk/opentelemetry-java-instrumentation that referenced this pull request Aug 15, 2023
@breedx-splk
Require server.address and server.port in the HTTP client getter (o…
6c21a09 
…pen-telemetry#9171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateuszrzeszutek @trask @laurit