Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npe with pulsar and ssl #9166

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Aug 9, 2023

Resolves #8939
As far as I understand this NPE happens because NettySslInstrumentationHandler.channelRegistered() is never called. In our test SslHandler is set up in the ChannelInitializer.initChannel. Pulsar does it from a background thread, by the time SslHandler is added the channel is already registered.

@laurit laurit requested a review from a team August 9, 2023 10:38
@mateuszrzeszutek mateuszrzeszutek enabled auto-merge (squash) August 9, 2023 11:46
@mateuszrzeszutek mateuszrzeszutek merged commit 6eec23c into open-telemetry:main Aug 9, 2023
43 of 44 checks passed
breedx-splk pushed a commit to breedx-splk/opentelemetry-java-instrumentation that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE in Netty 4 instrumentation
2 participants