Add javaagent instrumentation for ktor2 #9149
Conversation
|
|
||
| @Override | ||
| public boolean isHelperClass(String className) { | ||
| return className.startsWith("io.opentelemetry.extension.kotlin."); |
There was a problem hiding this comment.
Wouldn't this normally be injected by the coroutine instrumentation module? Do we need that here as well?
There was a problem hiding this comment.
This is more about muzzle, if we don't tell it that these are helpers it will fail with Missing class io.opentelemetry.javaagent.shaded.io.opentelemetry.extension.kotlin.ContextExtensionsKt
...ain/java/io/opentelemetry/javaagent/instrumentation/ktor/v2_0/HttpClientInstrumentation.java
Show resolved
Hide resolved
...rc/main/java/io/opentelemetry/javaagent/instrumentation/ktor/v2_0/ServerInstrumentation.java
Outdated
Show resolved
Hide resolved
…elemetry/javaagent/instrumentation/ktor/v2_0/ServerInstrumentation.java Co-authored-by: Mateusz Rzeszutek <[email protected]>
…elemetry/javaagent/instrumentation/ktor/v2_0/HttpClientInstrumentation.java Co-authored-by: Mateusz Rzeszutek <[email protected]>
|
@laurit @mateuszrzeszutek @trask I am using Ktor client. If I run the Java agent, it doest not extract imstrumentation automatically. How should I use it? OTEL APM does not instrument HTTP Request & Response sent by Ktor Client. I was wondering if I'm misunderstanding something and how to use it. Is this feature does not extract instrumentation automatically? Ticket |
|
hi @pkgonan! we would expect this to work, see https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/supported-libraries.md#libraries--frameworks as @laurit requested #9501 (comment), submitting a minimal repro the best way to help us identify the issue you may be facing |
Resolves #9144
Resolves #7755