Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the OpenTelemetry SDK version to 1.27.0 #8688

Merged
merged 18 commits into from
Jun 13, 2023
Merged

Update the OpenTelemetry SDK version to 1.27.0 #8688

merged 18 commits into from
Jun 13, 2023

Conversation

opentelemetrybot
Copy link
Collaborator

Update the OpenTelemetry SDK version to 1.27.0.

@opentelemetrybot opentelemetrybot requested a review from a team June 9, 2023 19:54
@trask
Copy link
Member

trask commented Jun 9, 2023

(I'm working on fixing)

@trask
Copy link
Member

trask commented Jun 9, 2023 •
edited
Loading

(reminder for myself, need to deal with opentelemetry-api-logs instrumentation)

@github-actions github-actions bot requested a review from theletterf June 9, 2023 22:55
@trask trask force-pushed the opentelemetrybot/update-opentelemetry-sdk-to-1.27.0 branch from 23932a5 to 31132be Compare June 10, 2023 03:43
@trask trask force-pushed the opentelemetrybot/update-opentelemetry-sdk-to-1.27.0 branch from dc34276 to e312233 Compare June 10, 2023 04:11
trask
trask reviewed Jun 13, 2023
View reviewed changes
...va/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java
Comment on lines +144 to +145
// global is needed for logging appenders
GlobalOpenTelemetry.set(OpenTelemetrySdk.builder().setLoggerProvider(loggerProvider).build());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is my proposed compromise related to https://github.com/open-telemetry/opentelemetry-java/blob/main/docs/sdk-configuration.md#the-global-instance-of-the-sdk

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek Jun 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this looks a bit hacky -- at the same time, I don't think I have any strong opinion on how we should solve this problem. Let's merge it as it is, and discuss the global issue in the SIG meeting

mateuszrzeszutek
mateuszrzeszutek approved these changes Jun 13, 2023
View reviewed changes
...va/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java
Comment on lines +144 to +145
// global is needed for logging appenders
GlobalOpenTelemetry.set(OpenTelemetrySdk.builder().setLoggerProvider(loggerProvider).build());
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek Jun 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this looks a bit hacky -- at the same time, I don't think I have any strong opinion on how we should solve this problem. Let's merge it as it is, and discuss the global issue in the SIG meeting

@laurit laurit merged commit bbb0527 into main Jun 13, 2023
@laurit laurit deleted the opentelemetrybot/update-opentelemetry-sdk-to-1.27.0 branch June 13, 2023 09:02
@trask trask mentioned this pull request Jun 13, 2023
Open
@jeanbisutti jeanbisutti mentioned this pull request Jun 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@laurit laurit laurit approved these changes

@theletterf theletterf Awaiting requested review from theletterf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@opentelemetrybot @trask @laurit @mateuszrzeszutek