replace "1" with the appropriate units #8668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
commented
Jun 7, 2023
...s-java8/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java8/Cpu.java
Outdated
Show resolved
Hide resolved
...ter-1.5/library/src/main/java/io/opentelemetry/instrumentation/micrometer/v1_5/Bridging.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/opentelemetry/instrumentation/micrometer/v1_5/OpenTelemetryFunctionTimer.java
Outdated
Show resolved
Hide resolved
…a/io/opentelemetry/instrumentation/micrometer/v1_5/OpenTelemetryFunctionTimer.java Co-authored-by: Mateusz Rzeszutek <[email protected]>
trask
reviewed
Jun 14, 2023
| @@ -89,7 +89,7 @@ List<AutoCloseable> registerObservers( | |||
| meter | |||
| .gaugeBuilder("process.runtime.jvm.system.cpu.load_1m") | |||
| .setDescription("Average CPU load of the whole system for the last minute") | |||
| .setUnit("1") | |||
| .setUnit("{run_queue_length}") | |||
There was a problem hiding this comment.
@zeitlinger I hope it's ok, I'm going to accept this change and merge, so we can get the (more important) parts into the upcoming release, since we don't have resolution yet on open-telemetry/semantic-conventions#95
Suggested change
| .setUnit("{run_queue_length}") | |
| .setUnit("1") |
…src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java8/Cpu.java
trask
reviewed
Jun 14, 2023
...va8/library/src/test/java/io/opentelemetry/instrumentation/runtimemetrics/java8/CpuTest.java
Outdated
Show resolved
Hide resolved
…src/test/java/io/opentelemetry/instrumentation/runtimemetrics/java8/CpuTest.java
trask
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace "1" with the appropriate units and don't fall back to "1" if the unit is unknown