Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename misleading advice methods #8485

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

laurit
Copy link
Contributor

@laurit laurit commented May 12, 2023

Rename advice method stopSpan to onExit when the method only closes scope and doesn't really ent the span.

@laurit laurit requested a review from a team May 12, 2023 10:33
@trask trask enabled auto-merge (squash) May 12, 2023 14:55
@trask trask merged commit ee00c7e into open-telemetry:main May 12, 2023
@laurit laurit deleted the rename-method branch July 6, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants