Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested http.route #8282

Merged
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ public static void methodEnter(

Context parentContext = Context.current();

// HttpRouteSource.CONTROLLER has userFirst true, and it will make http.route updated once
heyams marked this conversation as resolved.
Show resolved Hide resolved
// using the last portion of the nested path.
// HttpRouteSource.NESTED_CONTROLLER has useFirst false, and it will make http.route updated
// twice: 1st using the last portion of the nested path, 2nd time using the full nested path.
HttpRouteHolder.updateHttpRoute(
parentContext, HttpRouteSource.NESTED_CONTROLLER, httpRouteGetter(), exchange);
heyams marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a brief comment here about why NESTED_CONTROLLER is needed?


Expand Down