Http attributes: only set content_length when it's >0 #8114
Conversation
| internalSet( | ||
| attributes, SemanticAttributes.HTTP_REQUEST_CONTENT_LENGTH, requestContentLength(request)); | ||
| Long requestLength = requestContentLength(request); | ||
| if (requestLength != null && requestLength > 0) { |
There was a problem hiding this comment.
isn't requestLength 0 valid (and different from not being captured)?
There was a problem hiding this comment.
Hmm, true. I've a problem with Reactor Netty instrumentation, which reports content-lenght=0 even for GET & HEAD requests. WDYT about skipping 0 if method is GET/HEAD?
There was a problem hiding this comment.
can we apply that change just to the reactor netty HttpAttributesGetter?
There was a problem hiding this comment.
I don't think we can (well, not in a "nice" way) - since the getter simply returns the headers, which then get parsed in the extractor.
On a second thought, maybe we can live with this: the content-length=0 header is actually set on the outgoing HTTP request, so it's not like the instrumentation is lying. It's just a bit strange to see that in a GET request.
Fixes an issue encountered in #8111