Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the shardingsphere display the error tag #8109 #8110

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Fix the shardingsphere display the error tag #8109 #8110

merged 1 commit into from
Mar 23, 2023

Conversation

huange7
Copy link
Contributor

@huange7 huange7 commented Mar 22, 2023

Adding shardingsphere related classes to the JdbcIgnoredTypesConfigurer allows the actual execution of the statement to be captured

@huange7 huange7 requested a review from a team March 22, 2023 14:20
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 22, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: huange7 / name: Shelby Huang (c842663)

@mateuszrzeszutek
Copy link
Member

mateuszrzeszutek commented Mar 22, 2023 •
edited
Loading

Hey @huange7 ,
Can you rebase your commit and make sure it includes your GitHub user name as the author?

@huange7
Copy link
Contributor Author

huange7 commented Mar 22, 2023

Hey @huange7 , Can you rebase your commit and make sure it includes your GitHub user name as the author?

Okay. I'll do that. ^_^

@huange7 huange7 force-pushed the fix/shardingsphere-instrumentation branch 2 times, most recently from b568967 to 295490e Compare March 23, 2023 02:29
@huange7
Copy link
Contributor Author

huange7 commented Mar 23, 2023

Hey @huange7 , Can you rebase your commit and make sure it includes your GitHub user name as the author?

Hi @mateuszrzeszutek , should I reopen a pull request?

@huange7 huange7 force-pushed the fix/shardingsphere-instrumentation branch from 295490e to c842663 Compare March 23, 2023 03:21
@laurit
Copy link
Contributor

laurit commented Mar 23, 2023

@huange7 the pr looks fine, I think you can leave it as it is

@huange7
Copy link
Contributor Author

huange7 commented Mar 23, 2023

@huange7 the pr looks fine, I think you can leave it as it is

thanks

mateuszrzeszutek
mateuszrzeszutek approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huange7 !

@mateuszrzeszutek mateuszrzeszutek merged commit 2ebed6c into open-telemetry:main Mar 23, 2023
@laurit laurit mentioned this pull request Mar 23, 2023
Closed
@huange7 huange7 deleted the fix/shardingsphere-instrumentation branch May 18, 2023 11:42
@Jamel-jun
Copy link

When will you merge?

@huange7
Copy link
Contributor Author

huange7 commented Oct 17, 2023

When will you merge?

This PR has already been merged.

@Jamel-jun
Copy link

When will you merge?

This PR has already been merged.

Excuse me, which version of this PR will be released.

@trask
Copy link
Member

trask commented Oct 26, 2023

this PR was released in 1.25.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huange7 @mateuszrzeszutek @laurit @Jamel-jun @trask