Make spring boot service name detector handle BOOT-INF/classes #8101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
approved these changes
Mar 21, 2023
Comment on lines
+29
to
+30
| SpringBootServiceNameDetector guesser = new SpringBootServiceNameDetector(); | ||
| Resource result = guesser.createResource(config); |
There was a problem hiding this comment.
Suggested change
| SpringBootServiceNameDetector guesser = new SpringBootServiceNameDetector(); | |
| Resource result = guesser.createResource(config); | |
| SpringBootServiceNameDetector detector = new SpringBootServiceNameDetector(); | |
| Resource result = detector.createResource(config); |
There was a problem hiding this comment.
This is copy pasted from
WDYT about renaming this in both tests after this is merged?
There was a problem hiding this comment.
Oh sure. I think guesser was in the original name probably. No biggie.
trask
approved these changes
Mar 21, 2023
mateuszrzeszutek
approved these changes
Mar 22, 2023
| private final boolean addBootInfPrefix; | ||
|
|
||
| SystemHelper() { | ||
| ClassLoader contextClassLoader = Thread.currentThread().getContextClassLoader(); |
There was a problem hiding this comment.
Is getting the context CL necessary? This class runs in SDK setup time; in the javaagent it shouldn't have any context CL set (I've removed the setContextClassLoader calls a while ago)
There was a problem hiding this comment.
There isn't anything that says this has to be used only with javaagent. I think the context class loader defaults to system when it is not set (not set to null or some other class loader by the user).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When spring boot application is packaged in one jar
application.propertiesandapplication.ymlare underBOOT-INF/classes/.