Remove logging instrumentation #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson and
tylerbenson
as code owners
anuraaga
approved these changes
Jul 27, 2020
|
I am somewhat confused about logging story :) These were instrumentations to create spans from log messages, right? The story of injecting traceId/spanId into logging context is a separate story and was recently done by @anuraaga in java repo, right? Do we want to provide the same injecting functionality for earlier versions of log libraries? |
|
I think we definitely want to add injection to older libraries. Most tracers do it with scope decorators (callbacks run when creating / closing scope) but AFAIU SDK currently doesn't provide that - so much more work than the log4j2 plugin |
iNikem
approved these changes
Jul 27, 2020
|
This was referenced Aug 11, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #720