-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Sockpeer service. #7888
Conversation
Hey @rahuldimri , |
Working on this. |
...va/io/opentelemetry/instrumentation/api/instrumenter/net/PeerServiceAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...va/io/opentelemetry/instrumentation/api/instrumenter/net/PeerServiceAttributesExtractor.java
Outdated
Show resolved
Hide resolved
…trumentation/api/instrumenter/net/PeerServiceAttributesExtractor.java Co-authored-by: Mateusz Rzeszutek <[email protected]>
This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing the }
...va/io/opentelemetry/instrumentation/api/instrumenter/net/PeerServiceAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...o/opentelemetry/instrumentation/api/instrumenter/net/PeerServiceAttributesExtractorTest.java
Outdated
Show resolved
Hide resolved
...o/opentelemetry/instrumentation/api/instrumenter/net/PeerServiceAttributesExtractorTest.java
Outdated
Show resolved
Hide resolved
...o/opentelemetry/instrumentation/api/instrumenter/net/PeerServiceAttributesExtractorTest.java
Outdated
Show resolved
Hide resolved
…trumentation/api/instrumenter/net/PeerServiceAttributesExtractor.java Co-authored-by: Mateusz Rzeszutek <[email protected]>
…trumentation/api/instrumenter/net/PeerServiceAttributesExtractorTest.java Co-authored-by: Mateusz Rzeszutek <[email protected]>
…trumentation/api/instrumenter/net/PeerServiceAttributesExtractorTest.java Co-authored-by: Mateusz Rzeszutek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rahuldimri !
@mateuszrzeszutek thanks for your support in this PR. Do you mind to add labels on this issue ?. |
I'm not sure I'm following; what labels do you have in mind? |
hey @rahuldimri, could you elaborate on why you needed this? Is |
@rahuldimri fyi, I suspect the need for this will go away with open-telemetry/opentelemetry-specification#3402, where it's clarified that we should be populating (the equivalent of) |
No description provided.