Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix JMX usage examples #7877

Merged
merged 1 commit into from
Feb 22, 2023
Merged

fix JMX usage examples #7877

merged 1 commit into from
Feb 22, 2023

Conversation

zeitlinger
Copy link
Member

If the unit is a number, there's a ClassCastException.

However, I'm not sure if updating the documentation is the right fix

  • 1 is also used in some internal config files - e.g. tomcat
  • it's an incompatible change for users, such as myself

@zeitlinger
fix JMX usage examples
eff28e8 
If the unit is a number, there's a ClassCastException.

However, I'm not sure if updating the documentation is the right fix

- `1` is also used in some internal config files - e.g. [tomcat](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/4db65b6d1f9e7fa430b700c38eb6abb5dcae7d26/instrumentation/jmx-metrics/javaagent/src/main/resources/jmx/rules/tomcat.yaml#L4)
- it's an incompatible change for users, such as myself
@zeitlinger zeitlinger requested a review from a team February 22, 2023 12:41
@github-actions github-actions bot requested a review from theletterf February 22, 2023 12:41
@trask trask requested a review from PeterF778 February 22, 2023 19:47
PeterF778
PeterF778 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@PeterF778 PeterF778 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.
It looks like the issue appeared when migrating from snakeyaml parser.
There's also a need to change the built-in rules.

trask
trask approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @zeitlinger @PeterF778!

@trask trask merged commit 78e459e into open-telemetry:main Feb 22, 2023
@zeitlinger zeitlinger deleted the patch-2 branch February 23, 2023 14:18
@zeitlinger
Copy link
Member Author

@trask what about the imcompatible change?

  • Is it OK to break applications?
  • Was there a warning about the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterF778 PeterF778 PeterF778 approved these changes

@trask trask trask approved these changes

@theletterf theletterf Awaiting requested review from theletterf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeitlinger @trask @PeterF778