Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more semantic convention for RocketMQ trace #7871

Merged
merged 3 commits into from
Mar 1, 2023
Merged

Support more semantic convention for RocketMQ trace #7871

merged 3 commits into from
Mar 1, 2023

Conversation

aaron-ai
Copy link
Member

Fixes #7858

@aaron-ai aaron-ai requested a review from a team February 22, 2023 01:49
mateuszrzeszutek
mateuszrzeszutek reviewed Feb 22, 2023
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaron-ai can you add some tests that verify these attributes were added?

@aaron-ai
Copy link
Member Author

@aaron-ai can you add some tests that verify these attributes were added?

I will add related tests recently.

@aaron-ai
Copy link
Member Author

@mateuszrzeszutek PTAL.

@trask trask merged commit 88352fb into open-telemetry:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek left review comments

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support more semantic convention for RocketMQ trace
4 participants
@aaron-ai @laurit @mateuszrzeszutek @trask