Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated instrumentation-api-semconv code #7838

Merged
merged 2 commits into from
Feb 16, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove unused class
Mateusz Rzeszutek committed Feb 16, 2023

Unverified

No user is associated with the committer email.
commit ab776384bb3028478c5b765c228abac5504a0833
Original file line number Diff line number Diff line change
@@ -151,26 +151,4 @@ public void onEnd(
public SpanKey internalGetSpanKey() {
return SpanKey.HTTP_CLIENT;
}

private static final class NoopNetClientAttributesGetter<REQUEST, RESPONSE>
implements NetClientAttributesGetter<REQUEST, RESPONSE> {

@Nullable
@Override
public String getTransport(REQUEST request, @Nullable RESPONSE response) {
return null;
}

@Nullable
@Override
public String getPeerName(REQUEST request) {
return null;
}

@Nullable
@Override
public Integer getPeerPort(REQUEST request) {
return null;
}
}
}