Ignore janino classloader #7710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These obscure classloaders should be ignored completely, they process in-line class creation and should not branch out to interactions that are useful in distributed tracing.
laurit
approved these changes
Feb 2, 2023
|
Thanks for the approval |
mateuszrzeszutek
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7670
These obscure classloaders should be ignored completely, they process in-line class creation and should not branch out to interactions that are useful in distributed tracing. These two are responsible for outages recently in many of our applications due to driving up memory usage from WeakKey caching. In some cases, janino processing has ran wild and stimulated over 5.7mil WeakKey objects accounting for close to 200MB of heap.