Define the repository scope #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson and
tylerbenson
as code owners
anuraaga
reviewed
Jul 22, 2020
docs/scope.md
Outdated
| * Emitting spans and metrics (and in the future logs) | ||
| * System metrics | ||
| * Logging integrations | ||
| * Spring integrations |
There was a problem hiding this comment.
Suggested change
| * Spring integrations | |
| * Framework integrations (e.g., Spring) |
Honestly nothing comes to mind but there must be more frameworks than just Spring right? :D
There was a problem hiding this comment.
I think frameworks are covered under Instrumentation bullet above. Narrowed this down to Spring Boot starters for now(?)
|
One thing I didn't include, because I think may make more sense in SDK repo:
but we can discuss also |
jkwatson
approved these changes
Jul 31, 2020
iNikem
approved these changes
Jul 31, 2020
tylerbenson
approved these changes
Jul 31, 2020
anuraaga
approved these changes
Aug 1, 2020
|
Discussed with opentelemetry-java maintainers on Fri, and have agreement on this initial scope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to define the scope of this repository, mostly in relation to https://github.com/open-telemetry/opentelemetry-java, in order to help things to go to the right place.
If this scope is agreed upon, we can move https://github.com/open-telemetry/opentelemetry-java/tree/master/extensions/runtime_metrics over to this repository, and delete https://github.com/open-telemetry/opentelemetry-java/tree/master/extensions/logging/log4j2_extensions which was accidentally re-implemented in this repository (#735).
cc: @open-telemetry/java-approvers
Will wait for @jkwatson (back Jul 30) before making any decisions here, just want to get the ball rolling and hear any initial comments / feedback.