Implement consumer part of rocketmq new client instrumentation #7019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-ai
force-pushed
the
feature/support_rocketmq_consumer_instrumentation
branch
2 times, most recently
from
4550348 to
82d1cc3
Compare
laurit
reviewed
Nov 3, 2022
...opentelemetry/javaagent/instrumentation/rocketmqclient/v5_0/RocketMqInstrumenterFactory.java
Outdated
Show resolved
Hide resolved
|
@laurit , I noticed this issue #6804. It seems that the message consumption procedure of RocketMQ is more similar to Kafka rather than JMS, which means the process span is always there and the receive span is just an addition. So I add the message receiving instrumentation flag and keep it consistent with Kafka. |
trask
reviewed
Nov 9, 2022
...telemetry/javaagent/instrumentation/rocketmqclient/v5_0/RocketMqConsumerInstrumentation.java
Outdated
Show resolved
Hide resolved
...telemetry/javaagent/instrumentation/rocketmqclient/v5_0/RocketMqConsumerInstrumentation.java
Outdated
Show resolved
Hide resolved
aaron-ai
force-pushed
the
feature/support_rocketmq_consumer_instrumentation
branch
from
43bb101 to
71ce4c0
Compare
aaron-ai
force-pushed
the
feature/support_rocketmq_consumer_instrumentation
branch
from
71ce4c0 to
59ab0f3
Compare
...opentelemetry/javaagent/instrumentation/rocketmqclient/v5_0/RocketMqInstrumenterFactory.java
Outdated
Show resolved
Hide resolved
...telemetry/javaagent/instrumentation/rocketmqclient/v5_0/RocketMqConsumerInstrumentation.java
Outdated
Show resolved
Hide resolved
instrumentation/rocketmq/rocketmq-client/rocketmq-client-5.0/javaagent/build.gradle.kts
Outdated
Show resolved
Hide resolved
...ry/javaagent/instrumentation/rocketmqclient/v5_0/RocketMqMessageListenerInstrumentation.java
Outdated
Show resolved
Hide resolved
...ry/javaagent/instrumentation/rocketmqclient/v5_0/RocketMqMessageListenerInstrumentation.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/rocketmqclient/v5_0/AbstractRocketMqClientTest.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/rocketmqclient/v5_0/AbstractRocketMqClientTest.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/rocketmqclient/v5_0/AbstractRocketMqClientTest.java
Outdated
Show resolved
Hide resolved
|
Hey @aaron-ai , |
aaron-ai
force-pushed
the
feature/support_rocketmq_consumer_instrumentation
branch
2 times, most recently
from
c5012d4 to
75ae828
Compare
aaron-ai
force-pushed
the
feature/support_rocketmq_consumer_instrumentation
branch
from
75ae828 to
96b297b
Compare
|
@mateuszrzeszutek thanks for your opnions, all issues were fixed already. but there were a few unpassed tests not related to this PR seemingly, could you re-run the unpassed tests? |
…ketmq_consumer_instrumentation
|
@aaron-ai heads up I merged main into your branch to fix the CI failures |
trask
approved these changes
Nov 15, 2022
...entelemetry/javaagent/instrumentation/rocketmqclient/v5_0/ConsumeServiceInstrumentation.java
Outdated
Show resolved
Hide resolved
...a/io/opentelemetry/javaagent/instrumentation/rocketmqclient/v5_0/MessageListenerWrapper.java
Outdated
Show resolved
Hide resolved
...javaagent/instrumentation/rocketmqclient/v5_0/RocketMqConsumerProcessAttributeExtractor.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6764 , This PR is about the consumer part.