Add docs for library instrumentation of RocketMQ remoting-based client #6960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-ai
changed the title
aaron-ai
force-pushed
the
add_library_instrumentation_for_rocketmq
branch
from
75ff599 to
4afa624
Compare
|
I'm not sure why @theletterf wasn't automatically added as a reviewer, I will investigate.. |
theletterf
suggested changes
Oct 24, 2022
instrumentation/rocketmq/rocketmq-client/rocketmq-client-4.8/library/README.md
Outdated
Show resolved
Hide resolved
instrumentation/rocketmq/rocketmq-client/rocketmq-client-4.8/library/README.md
Outdated
Show resolved
Hide resolved
instrumentation/rocketmq/rocketmq-client/rocketmq-client-4.8/library/README.md
Outdated
Show resolved
Hide resolved
instrumentation/rocketmq/rocketmq-client/rocketmq-client-4.8/library/README.md
Outdated
Show resolved
Hide resolved
instrumentation/rocketmq/rocketmq-client/rocketmq-client-4.8/library/README.md
Show resolved
Hide resolved
…ibrary/README.md Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
…ibrary/README.md Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
…ibrary/README.md Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
…ibrary/README.md Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
oh, right, this is what @mateuszrzeszutek mentioned the other week, I submitted a PR to add file extension support to the component-owners action: dyladan/component-owners#14 |
trask
approved these changes
Oct 25, 2022
instrumentation/rocketmq/rocketmq-client/rocketmq-client-4.8/library/README.md
Outdated
Show resolved
Hide resolved
instrumentation/rocketmq/rocketmq-client/rocketmq-client-4.8/library/README.md
Outdated
Show resolved
Hide resolved
instrumentation/rocketmq/rocketmq-client/rocketmq-client-4.8/library/README.md
Outdated
Show resolved
Hide resolved
instrumentation/rocketmq/rocketmq-client/rocketmq-client-4.8/library/README.md
Show resolved
Hide resolved
…ibrary/README.md Co-authored-by: Trask Stalnaker <[email protected]>
…ibrary/README.md Co-authored-by: Trask Stalnaker <[email protected]>
aaron-ai
force-pushed
the
add_library_instrumentation_for_rocketmq
branch
from
586cf4a to
ed21585
Compare
aaron-ai
force-pushed
the
add_library_instrumentation_for_rocketmq
branch
2 times, most recently
from
a6f61d1 to
8129731
Compare
aaron-ai
force-pushed
the
add_library_instrumentation_for_rocketmq
branch
from
8129731 to
667f95a
Compare
|
thx @aaron-ai! |
6 tasks
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
open-telemetry#6960) Fixes open-telemetry#6954 Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]>
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
open-telemetry#6960) Fixes open-telemetry#6954 Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6954