Add section to coding guidelines on Optional usage #6894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Oct 18, 2022
theletterf
approved these changes
Oct 18, 2022
Comment on lines
+135
to
+136
| It is ok to use `Optional` in places where it does not leak into public API signatures and where | ||
| performance is not critical. |
There was a problem hiding this comment.
Suggested change
| It is ok to use `Optional` in places where it does not leak into public API signatures and where | |
| performance is not critical. | |
| Use `Optional` where it does not leak into public API signatures and where | |
| performance is not a critical aspect. |
There was a problem hiding this comment.
maybe It is acceptable to use? we don't exactly want to "recommend" it, only mention that it is "ok" (i.e. author's choice to use or not)
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
This was discussed a long while back, but never documented (and recently came up in open-telemetry#6889) Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
This was discussed a long while back, but never documented (and recently came up in open-telemetry#6889) Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed a long while back, but never documented (and recently came up in #6889)