Update to slf4j 2.0.2 #6774
Merged
Update to slf4j 2.0.2 #6774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Oct 3, 2022
Comment on lines
76
to
114
| configurations.testRuntimeClasspath { | ||
| resolutionStrategy { | ||
| // requires old logback (and therefore also old slf4j) | ||
| force("ch.qos.logback:logback-classic:1.2.11") | ||
| force("org.slf4j:slf4j-api:1.7.36") | ||
| } | ||
| } | ||
|
|
||
| configurations.named("vaadin142TestRuntimeClasspath") { | ||
| resolutionStrategy { | ||
| // requires old logback (and therefore also old slf4j) | ||
| force("ch.qos.logback:logback-classic:1.2.11") | ||
| force("org.slf4j:slf4j-api:1.7.36") | ||
| } | ||
| } | ||
|
|
||
| configurations.named("vaadin14LatestTestRuntimeClasspath") { | ||
| resolutionStrategy { | ||
| // requires old logback (and therefore also old slf4j) | ||
| force("ch.qos.logback:logback-classic:1.2.11") | ||
| force("org.slf4j:slf4j-api:1.7.36") | ||
| } | ||
| } | ||
|
|
||
| configurations.named("vaadin16TestRuntimeClasspath") { | ||
| resolutionStrategy { | ||
| // requires old logback (and therefore also old slf4j) | ||
| force("ch.qos.logback:logback-classic:1.2.11") | ||
| force("org.slf4j:slf4j-api:1.7.36") | ||
| } | ||
| } | ||
|
|
||
| configurations.named("latestDepTestRuntimeClasspath") { | ||
| resolutionStrategy { | ||
| // requires old logback (and therefore also old slf4j) | ||
| force("ch.qos.logback:logback-classic:1.2.11") | ||
| force("org.slf4j:slf4j-api:1.7.36") | ||
| } | ||
| } |
There was a problem hiding this comment.
Would something like
Suggested change
| configurations.testRuntimeClasspath { | |
| resolutionStrategy { | |
| // requires old logback (and therefore also old slf4j) | |
| force("ch.qos.logback:logback-classic:1.2.11") | |
| force("org.slf4j:slf4j-api:1.7.36") | |
| } | |
| } | |
| configurations.named("vaadin142TestRuntimeClasspath") { | |
| resolutionStrategy { | |
| // requires old logback (and therefore also old slf4j) | |
| force("ch.qos.logback:logback-classic:1.2.11") | |
| force("org.slf4j:slf4j-api:1.7.36") | |
| } | |
| } | |
| configurations.named("vaadin14LatestTestRuntimeClasspath") { | |
| resolutionStrategy { | |
| // requires old logback (and therefore also old slf4j) | |
| force("ch.qos.logback:logback-classic:1.2.11") | |
| force("org.slf4j:slf4j-api:1.7.36") | |
| } | |
| } | |
| configurations.named("vaadin16TestRuntimeClasspath") { | |
| resolutionStrategy { | |
| // requires old logback (and therefore also old slf4j) | |
| force("ch.qos.logback:logback-classic:1.2.11") | |
| force("org.slf4j:slf4j-api:1.7.36") | |
| } | |
| } | |
| configurations.named("latestDepTestRuntimeClasspath") { | |
| resolutionStrategy { | |
| // requires old logback (and therefore also old slf4j) | |
| force("ch.qos.logback:logback-classic:1.2.11") | |
| force("org.slf4j:slf4j-api:1.7.36") | |
| } | |
| } | |
| configurations { | |
| listOf(testRuntimeClasspath, | |
| named("vaadin142TestRuntimeClasspath"), | |
| named("vaadin14LatestTestRuntimeClasspath"), | |
| named("vaadin16TestRuntimeClasspath"), | |
| named("latestDepTestRuntimeClasspath")) | |
| .forEach { | |
| resolutionStrategy { | |
| // requires old logback (and therefore also old slf4j) | |
| force("ch.qos.logback:logback-classic:1.2.11") | |
| force("org.slf4j:slf4j-api:1.7.36") | |
| } | |
| } | |
| } |
work? (same in the spring-kafka build file)
trask
added a commit
that referenced
this pull request
Oct 6, 2022
This seems nice for after pushing `spotlessApply` on an otherwise approved and passing PR. I just enabled it and tried it on #6774. (somewhat related to #6743) Btw, I thought this was helpful explanation > After you enable auto-merge for a pull request, if someone who does not have write permissions to the repository pushes new changes to the head branch or switches the base branch of the pull request, auto-merge will be disabled. For example, if a maintainer enables auto-merge for a pull request from a fork, auto-merge will be disabled after a contributor pushes new changes to the pull request. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request#about-auto-merge
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
~testLatestDeps is failing, see open-telemetry#6791~
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
This seems nice for after pushing `spotlessApply` on an otherwise approved and passing PR. I just enabled it and tried it on open-telemetry#6774. (somewhat related to open-telemetry#6743) Btw, I thought this was helpful explanation > After you enable auto-merge for a pull request, if someone who does not have write permissions to the repository pushes new changes to the head branch or switches the base branch of the pull request, auto-merge will be disabled. For example, if a maintainer enables auto-merge for a pull request from a fork, auto-merge will be disabled after a contributor pushes new changes to the pull request. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request#about-auto-merge
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
~testLatestDeps is failing, see open-telemetry#6791~
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
This seems nice for after pushing `spotlessApply` on an otherwise approved and passing PR. I just enabled it and tried it on open-telemetry#6774. (somewhat related to open-telemetry#6743) Btw, I thought this was helpful explanation > After you enable auto-merge for a pull request, if someone who does not have write permissions to the repository pushes new changes to the head branch or switches the base branch of the pull request, auto-merge will be disabled. For example, if a maintainer enables auto-merge for a pull request from a fork, auto-merge will be disabled after a contributor pushes new changes to the pull request. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request#about-auto-merge
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
~testLatestDeps is failing, see open-telemetry#6791~
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
This seems nice for after pushing `spotlessApply` on an otherwise approved and passing PR. I just enabled it and tried it on open-telemetry#6774. (somewhat related to open-telemetry#6743) Btw, I thought this was helpful explanation > After you enable auto-merge for a pull request, if someone who does not have write permissions to the repository pushes new changes to the head branch or switches the base branch of the pull request, auto-merge will be disabled. For example, if a maintainer enables auto-merge for a pull request from a fork, auto-merge will be disabled after a contributor pushes new changes to the pull request. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request#about-auto-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testLatestDeps is failing, see #6791