Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConditionalResourceProvider in the Spring Boot service name provider #6587

Merged

Conversation

mateuszrzeszutek
Copy link
Member

No description provided.

@mateuszrzeszutek mateuszrzeszutek requested review from breedx-splk and a team September 12, 2022 10:46
@mateuszrzeszutek mateuszrzeszutek force-pushed the spring-boot-conditional-resource branch from c179b37 to 0ee6600 Compare September 12, 2022 10:46
@mateuszrzeszutek mateuszrzeszutek added this to the v1.18.0 milestone Sep 12, 2022
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for following this up.

@mateuszrzeszutek mateuszrzeszutek force-pushed the spring-boot-conditional-resource branch from d3bfe50 to 991e8f2 Compare September 13, 2022 11:52
@trask trask merged commit 9081ced into open-telemetry:main Sep 13, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the spring-boot-conditional-resource branch September 13, 2022 14:27
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
…der (open-telemetry#6587)

* Use ConditionalResourceProvider in the Spring Boot service name provider

* make it a bit simpler

* add order=100

* add comment

* spellcheck
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
…der (open-telemetry#6587)

* Use ConditionalResourceProvider in the Spring Boot service name provider

* make it a bit simpler

* add order=100

* add comment

* spellcheck
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
…der (open-telemetry#6587)

* Use ConditionalResourceProvider in the Spring Boot service name provider

* make it a bit simpler

* add order=100

* add comment

* spellcheck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants