Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix liberty net.peer.port #6274

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Fix liberty net.peer.port #6274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ry/javaagent/instrumentation/liberty/dispatcher/LibertyDispatcherNetAttributesGetter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public String transport(LibertyRequest libertyRequest) {
@Override
@Nullable
public Integer peerPort(LibertyRequest libertyRequest) {
return libertyRequest.getServerPort();
return libertyRequest.peerPort();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also remove getServerPort method?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably start capturing net.host.* attributes, but may be worth waiting for the proposed net.* attribute changes to go through the spec first, I'll open an issue to track

}

@Override
Expand Down