Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always pass Context when recording HttpServerMetrics #6223

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Always pass Context when recording HttpServerMetrics #6223

merged 1 commit into from
Jun 27, 2022

Conversation

mateuszrzeszutek
Copy link
Member

Related to #6209

@mateuszrzeszutek mateuszrzeszutek requested a review from a team June 27, 2022 09:15
trask
trask approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 72e0b26 into open-telemetry:main Jun 27, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the fix-HttpServerMetrics-context branch June 27, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@anuraaga anuraaga anuraaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateuszrzeszutek @anuraaga @trask