Add tomcat-jdbc connection pool metrics instrumentation #6102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
May 27, 2022
.../io/opentelemetry/javaagent/instrumentation/tomcat/jdbc/TomcatJdbcInstrumentationModule.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
May 27, 2022
...va/io/opentelemetry/javaagent/instrumentation/tomcat/jdbc/TomcatJdbcInstrumentationTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
May 27, 2022
...va/io/opentelemetry/javaagent/instrumentation/tomcat/jdbc/TomcatJdbcInstrumentationTest.java
Outdated
Show resolved
Hide resolved
laurit
approved these changes
May 27, 2022
trask
approved these changes
May 27, 2022
...va/io/opentelemetry/javaagent/instrumentation/tomcat/jdbc/TomcatJdbcInstrumentationTest.java
Outdated
Show resolved
Hide resolved
|
can you update |
trask
reviewed
May 27, 2022
...java/io/opentelemetry/javaagent/instrumentation/tomcat/jdbc/TomcatConnectionPoolMetrics.java
Show resolved
Hide resolved
trask
reviewed
Jun 2, 2022
| testing.clearData(); | ||
|
|
||
| // then | ||
| assertNoConnectionPoolMetrics(); |
There was a problem hiding this comment.
do we need to wait at least [metric interval] before this assertion?
also having similar conversation #6099 (comment)
|
thx @breedx-splk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds metrics instrumentation for the Tomcat jdbc connection pool. It includes tracking of:
db.client.connections.pending_requests)