Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhance][pulsar] add apache-pulsar client support #5926
[enhance][pulsar] add apache-pulsar client support #5926
Changes from 46 commits
693b89b
7086bd8
29cc849
1ed1686
e347fa8
883c401
47e9f1c
9cc4f45
09052da
2e127e6
975671c
f22dd03
0845f0e
34c425a
1e6aa3d
d23932b
57c7b74
79ca3a2
6755ae6
2f5ab6f
a7f3da7
1f6faed
a2fe9a3
b87b21a
92f5c72
63438b6
40c1115
7184126
333f636
db57a7b
3de32af
01b616a
5207cc9
1f307c6
fbeb11e
ab5f0c5
e0f214d
8328ca1
5a6917b
c8b7551
7fe7329
8dd1207
b704cd8
90268c2
2e02517
5c05c29
cdc53bd
399d63f
cbd934f
2d44361
9d0af62
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you try MessageListener and it didn't work? there is some magic that should enhance lambdas: #4182
hasSuperType
is a more expensive matcher compared tonamed
however, so the current implementation could still be betterThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, too. The current implementation works fine, so it needn't to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your review!