Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record exception in dubbo high version #5892

Merged
merged 1 commit into from
Apr 20, 2022
Merged

record exception in dubbo high version #5892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...figure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/TracingFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public Result invoke(Invoker<?> invoker, Invocation invocation) {
throw e;
}
if (isSynchronous) {
instrumenter.end(context, request, result, null);
instrumenter.end(context, request, result, result.getException());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should async case also use something like throwable != null ? throwable : result.getException()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is only for server side. the async case is for the client in dubbo. I check the code in brave too, it only use 'result.getException()' in sync case too.

}
return result;
}
Expand Down