Tweak Guava WithSpan test pattern. #5744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
commented
Apr 4, 2022
| static final IllegalArgumentException FAILURE = new IllegalArgumentException("Boom"); | ||
|
|
||
| @WithSpan | ||
| SettableFuture<String> completable() { |
There was a problem hiding this comment.
I went with this name expecting to extract an interface in a shared location
mateuszrzeszutek
approved these changes
Apr 4, 2022
trask
approved these changes
Apr 4, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking through the TracedWithSpan tests to potentially share logic and realized the pattern looks a bit weird to me. We pass in a future to the traced method, which is not a real-world pattern - indeed if the same future gets passed through multiple WithSpan methods the behavior is undefined. We don't expect that problem to happen in the real world (though maybe we do want to add some sort of detection / logging of this) but either way it would be good for the tests to match real world patterns better.
Will in another PR extract these tests into a shared location