-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for jboss-logmanager #5737
Add support for jboss-logmanager #5737
Conversation
Signed-off-by: Cuichen Li <[email protected]>
Signed-off-by: Cuichen Li <[email protected]>
Signed-off-by: Cuichen Li <[email protected]>
Signed-off-by: Cuichen Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cuichenli this is awesome, thx for doing this!
I sent a couple of additional commits to your PR to clean up some of the duplication with #5498.
Resolves #5013
...ava/io/opentelemetry/javaagent/instrumentation/jboss_logmanager/v2_1/LoggingEventMapper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Cuichen Li <[email protected]>
Signed-off-by: Cuichen Li <[email protected]>
@trask thanks for the commits. One question, why do we need to set the base version to 1.1? |
Signed-off-by: Cuichen Li <[email protected]>
We typically set the base version to the earliest version where the instrumentation works. And we use If there something you want to use / support that requires bumping the base version we can definitely discuss that. For a bit of background why we try to support old library versions in the javaagent when (reasonably) possible, check out https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/VERSIONING.md#javaagent-instrumentation
👍 |
so in the build.gradle file we set the version to be 1.1 but in the package level, i am still specifying the version 2.1, is that acceptable? or should i remove the version part? |
...try/javaagent/instrumentation/jbosslogmanager/v2_1/JbossLogmanagerInstrumentationModule.java
Outdated
Show resolved
Hide resolved
…nstrumentation into add-jboss-logmanager-instrumentation
Signed-off-by: Cuichen Li <[email protected]>
thx @cuichenli! |
* initialize the package Signed-off-by: Cuichen Li <[email protected]> * add jboss-logmanger 2.1 instrumentation Signed-off-by: Cuichen Li <[email protected]> * rename the test Signed-off-by: Cuichen Li <[email protected]> * clean comment Signed-off-by: Cuichen Li <[email protected]> * Revert "Add JBoss java.util.logging support (open-telemetry#5498)" This reverts commit 8b26cef. * Remove extra directory * Remove old jboss log manager test * Ensure no cross interference * Change base version to 1.1 * fix styles Signed-off-by: Cuichen Li <[email protected]> * run spotless apply Signed-off-by: Cuichen Li <[email protected]> * fix codenarc Signed-off-by: Cuichen Li <[email protected]> * change the package version and additional module name Signed-off-by: Cuichen Li <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]>
Signed-off-by: Cuichen Li [email protected]