Use internal Marshaler in testing exporters instead of gRPC. #5332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Feb 10, 2022
trask
approved these changes
Feb 10, 2022
|
we got 👍 from @jack-berg, so merging 😄 |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #5314, I realized that as we are already overriding the exporters from what our normal javaagent (and smoke tests) use, there actually isn't a reason to care that much about whether gRPC or okhttp transport is used. And thinking more, then I realized that given our versions are always aligned, using some simple SDK internal APIs from our testing artifact seems like a reasonable, if slightly questionable, approach to avoid it all completely. I approve :) /cc @jkwatson @jack-berg in case you don't