Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename (and move around) log4j instrumentation modules #4937

Merged
merged 6 commits into from
Dec 20, 2021
Merged

Rename (and move around) log4j instrumentation modules #4937

merged 6 commits into from
Dec 20, 2021

Conversation

trask
Copy link
Member

@trask trask commented Dec 18, 2021

Resolves #4912

Resulting log4j instrumentation directory structure:

instrumentation/
  log4j/
    log4j-appender-2.16/
      library/
    log4j-mdc-1.2/
      javaagent/
    log4j-thread-context/
      log4j-thread-context-2.7/
        javaagent/
      log4j-thread-context-2.16/
        javaagent/
        library-autoconfigure/
      log4j-thread-context-2-common/
        testing/

Corresponding doc updates appended to #4915

@trask trask marked this pull request as ready for review December 18, 2021 19:44
@trask
Copy link
Member Author

trask commented Dec 20, 2021

going ahead and merging b/c worried about conflicts with all my inflight logging PRs 😭, but please feel free to still review/comment on this PR and I will resolve in follow-up(s)

@trask trask merged commit 5d2cc7e into open-telemetry:main Dec 20, 2021
@trask trask deleted the split-log4j-instrumentation branch December 20, 2021 03:58
trask added a commit that referenced this pull request Jan 5, 2022
* Update log4j instrumentation docs for 1.10.0 release

* More log4j doc changes for 0.10.0

* Updates for #4937

* Fix log4j documentation

* Update instrumentation/log4j/log4j-2.16/library/README.md

Co-authored-by: jack-berg <[email protected]>
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
…y#4937)

* Rename to log4j-thread-context

* Rename to log4j-mdc-1.2

* move

* update

* subdir
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* Update log4j instrumentation docs for 1.10.0 release

* More log4j doc changes for 0.10.0

* Updates for open-telemetry#4937

* Fix log4j documentation

* Update instrumentation/log4j/log4j-2.16/library/README.md

Co-authored-by: jack-berg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should log4j library-autoconfigure depend on library?
2 participants