-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace DNS resolution in reactor-netty #4627
Trace DNS resolution in reactor-netty #4627
Conversation
.../io/opentelemetry/javaagent/instrumentation/netty/v4_1/InstrumentedAddressResolverGroup.java
Show resolved
Hide resolved
include(":instrumentation:netty:netty-4.1:javaagent") | ||
include(":instrumentation:netty:netty-4.1-common:javaagent") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can netty-4.1-common:javaagent
be merged into netty-4.1:javaagent
and have reactor-netty:javaavent depend directly on netty-4.1:javaagent
? or is there advantage to keeping it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it can! I don't know why I haven't thought of that 🙈
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to go back to the netty-4.1-common
idea, muzzle failed when I merged that into the main 4.1 module:
MUZZLE PASSED io.opentelemetry.javaagent.instrumentation.netty.v4_1.NettyInstrumentationModule BUT FAILURE WAS EXPECTED
...ain/java/io/opentelemetry/javaagent/instrumentation/reactornetty/v1_0/ConnectionWrapper.java
Outdated
Show resolved
Hide resolved
...telemetry/javaagent/instrumentation/reactornetty/v1_0/TransportConnectorInstrumentation.java
Outdated
Show resolved
Hide resolved
* Trace DNS resolution in reactor-netty * Code review comments * removed a little too much * implementation -> api * revert and make muzzle happy
A continuation of #4587