Remove unshaded javax.annotation classes from bootstrap class loader #4454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
laurit
approved these changes
Oct 20, 2021
|
Did this come in with a transitive? I know we did our migration recently but thought it was compileOnly |
oh good point, i see it's |
|
@trask At the same time you can move it into java-conventions where it was supposed to be :P |
yup, fixing that now |
trask
changed the title
iNikem
approved these changes
Oct 21, 2021
anuraaga
reviewed
Oct 21, 2021
| @@ -22,6 +22,7 @@ | |||
|
|
|||
| package io.opentelemetry.instrumentation.rxjava2; | |||
|
|
|||
| import io.opentelemetry.api.internal.GuardedBy; | |||
There was a problem hiding this comment.
Can you copy this into instrumentation api instead?
mateuszrzeszutek
approved these changes
Oct 21, 2021
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…pen-telemetry#4454) * Fix shading * Revert "Fix shading" This reverts commit 2aad3cf. * Make javax.annotations compileOnly * Replace checker GuardedBy with otel api internal GuardedBy * Fix build * Fix errorprone failures * Remove extra newline * Move internal GuardedBy to instrumentation-api * empty commit * empty commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably deserves a 1.7.1 patch unless there's reason to believe that since they're just annotations they shouldn't cause problems.
Created issue #4455 to add a test to guard against this.