-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync gradle-plugins version with main project #4248
Changes from 7 commits
5c53d70
c248d2a
7db76b4
5f2d443
43646e1
c968484
06c81a5
1926301
acb827a
7709189
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -253,8 +253,6 @@ jobs: | |
|
||
examples: | ||
runs-on: ubuntu-latest | ||
# When we make PR against pre-release branch examples may point to yet-unpublished version | ||
if: github.base_ref == 'main' | ||
steps: | ||
- uses: actions/[email protected] | ||
with: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -159,7 +159,7 @@ jobs: | |
with: | ||
job-id: jdk11 | ||
remote-build-cache-proxy-enabled: false | ||
arguments: assemble final closeAndReleaseSonatypeStagingRepository --stacktrace -Prelease.version=${{ github.event.inputs.version }} | ||
arguments: assemble final closeAndReleaseSonatypeStagingRepository --stacktrace | ||
env: | ||
SONATYPE_USER: ${{ secrets.SONATYPE_USER }} | ||
SONATYPE_KEY: ${{ secrets.SONATYPE_KEY }} | ||
|
@@ -168,6 +168,14 @@ jobs: | |
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }} | ||
GPG_PASSWORD: ${{ secrets.GPG_PASSWORD }} | ||
|
||
# TODO (trask) cache gradle wrapper? | ||
- name: Build and publish gradle plugins | ||
env: | ||
GRADLE_PUBLISH_KEY: ${{ secrets.GRADLE_PUBLISH_KEY }} | ||
GRADLE_PUBLISH_SECRET: ${{ secrets.GRADLE_PUBLISH_SECRET }} | ||
run: ../gradlew build publishPlugins | ||
working-directory: gradle-plugins | ||
|
||
- name: Create Release | ||
id: create_release | ||
uses: actions/[email protected] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,8 +29,8 @@ dependencies { | |
implementation(gradleApi()) | ||
implementation(localGroovy()) | ||
|
||
implementation("io.opentelemetry.instrumentation.muzzle-generation:io.opentelemetry.instrumentation.muzzle-generation.gradle.plugin:0.8.0") | ||
implementation("io.opentelemetry.instrumentation.muzzle-check:io.opentelemetry.instrumentation.muzzle-check.gradle.plugin:0.8.0") | ||
implementation("io.opentelemetry.instrumentation.muzzle-generation:io.opentelemetry.instrumentation.muzzle-generation.gradle.plugin:${version}") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. conventions always include plugins as composite, probably can skip version altogether. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice 👍 |
||
implementation("io.opentelemetry.instrumentation.muzzle-check:io.opentelemetry.instrumentation.muzzle-check.gradle.plugin:${version}") | ||
|
||
implementation("org.eclipse.aether:aether-connector-basic:1.1.0") | ||
implementation("org.eclipse.aether:aether-transport-http:1.1.0") | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
allprojects { | ||
if (findProperty("otel.stable") != "true") { | ||
version = "1.8.0-alpha-SNAPSHOT" | ||
} else { | ||
version = "1.8.0-SNAPSHOT" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not needed any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking now that we will remove -SNAPSHOT from artifact version at the same time, the locally published artifacts won't have -SNAPSHOT, and so this will work... I could definitely be wrong...