Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit RxJava3 muzzle check version range #4022

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

mateuszrzeszutek
Copy link
Member

It looks like in RxJava 3.1.1 some internal classes were moved to non-internal packages:

FAILED MUZZLE VALIDATION: io.opentelemetry.javaagent.instrumentation.rxjava3.RxJava3InstrumentationModule mismatches:
-- io.opentelemetry.instrumentation.rxjava3.TracingAssembly:193 Missing field io.reactivex.rxjava3.internal.fuseable.QueueSubscription qs in class io.opentelemetry.instrumentation.rxjava3.TracingConditionalSubscriber
-- io.opentelemetry.instrumentation.rxjava3.TracingAssembly:193 Missing field io.reactivex.rxjava3.internal.fuseable.ConditionalSubscriber downstream in class io.opentelemetry.instrumentation.rxjava3.TracingConditionalSubscriber
-- io.opentelemetry.instrumentation.rxjava3.TracingAssembly:196 Missing field io.reactivex.rxjava3.internal.fuseable.QueueSubscription qs in class io.opentelemetry.instrumentation.rxjava3.TracingSubscriber
-- io.opentelemetry.instrumentation.rxjava3.TracingConditionalSubscriber:70 Missing class io.reactivex.rxjava3.internal.fuseable.QueueSubscription
-- io.opentelemetry.instrumentation.rxjava3.TracingAssembly:192 Missing class io.reactivex.rxjava3.internal.fuseable.ConditionalSubscriber
-- io.opentelemetry.instrumentation.rxjava3.TracingObserver:63 Missing class io.reactivex.rxjava3.internal.fuseable.QueueDisposable
-- io.opentelemetry.instrumentation.rxjava3.TracingConditionalSubscriber:36 Missing method io.reactivex.rxjava3.internal.subscribers.BasicFuseableConditionalSubscriber#<init>(Lio/reactivex/rxjava3/internal/fuseable/ConditionalSubscriber;)V
-- io.opentelemetry.instrumentation.rxjava3.TracingAssembly:211 Missing field io.reactivex.rxjava3.internal.fuseable.QueueDisposable qd in class io.opentelemetry.instrumentation.rxjava3.TracingObserver

Before (3-3.1):

import io.reactivex.rxjava3.internal.fuseable.ConditionalSubscriber;
import io.reactivex.rxjava3.internal.fuseable.QueueSubscription;

After (3.1.1+):

import io.reactivex.rxjava3.operators.ConditionalSubscriber;
import io.reactivex.rxjava3.operators.QueueSubscription;

@laurit laurit merged commit 1363e0c into open-telemetry:main Aug 30, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the rxjava3-muzzle-fix branch August 30, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants