Remove zipkin from otel collector smoke test config #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
jkwatson
approved these changes
Aug 25, 2021
iNikem
reviewed
Aug 25, 2021
| @@ -44,7 +44,8 @@ protected void startEnvironment() { | |||
| backend.start(); | |||
|
|
|||
| collector = | |||
| new GenericContainer<>(DockerImageName.parse("otel/opentelemetry-collector-dev:latest")) | |||
| new GenericContainer<>( | |||
| DockerImageName.parse("otel/opentelemetry-collector-contrib-dev:latest")) | |||
There was a problem hiding this comment.
If we switch to contrib, which continues to have zipkin, then why do we remove zipkin? :)
There was a problem hiding this comment.
ah, when fixing the examples failure, I noticed that we didn't need zipkin in there, so removed it
but smoke tests need the zipkin receiver for the zipkin exporter test, so switched to contrib
I'm going to merge to unblock other PRs, but I can bring back zipkin in the examples and switch that to contrib if you prefer
There was a problem hiding this comment.
A, I now see what is happening. No need, current state is good.
iNikem
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples build just started failing due to open-telemetry/opentelemetry-collector#3889