-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert okhttp library instrumentation back to using standard reflection to support Android usage #3910
Conversation
Since this is a regression for Android, could we get a patch release with this commit, possibly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a regression for Android, could we get a patch release with this commit, possibly?
yes, this definitely fits our criteria for patching
@@ -24,22 +23,19 @@ | |||
private static final Cache<Request, Context> contextsByRequest = | |||
Cache.newBuilder().setWeakKeys().build(); | |||
|
|||
@Nullable private static MethodHandle timeoutMethodHandle; | |||
@Nullable private static MethodHandle cloneMethodHandle; | |||
@Nullable private static Method timeoutMethod; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a comment here about not being able to use method handles (so no one changes it back), at least until we get some build tooling in place to prevent similar to otel-java repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
…on to support Android usage (#3910) (#3936) * Revert back to using standard reflection to support Android usage * Add a comment about not using MethodHandles Co-authored-by: John Watson <[email protected]>
It turns out that MethodHandles are not supported on Android API levels 21-25.