Fix tomcat 9.0.52 #3789
Fix tomcat 9.0.52 #3789
Conversation
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
| testLibrary("org.apache.tomcat.embed:tomcat-embed-core:8.0.41") | ||
| testLibrary("org.apache.tomcat.embed:tomcat-embed-jasper:8.0.41") |
There was a problem hiding this comment.
is this part of the comment still relevant?
| testLibrary("org.apache.tomcat.embed:tomcat-embed-core:8.0.41") | |
| testLibrary("org.apache.tomcat.embed:tomcat-embed-jasper:8.0.41") | |
| // Tests need at least version 8.0.41 to have necessary classes to configure the embedded tomcat... | |
| // ... but not newer that version 10, because its servlet 5. | |
| testLibrary("org.apache.tomcat.embed:tomcat-embed-core:8.0.41") | |
| testLibrary("org.apache.tomcat.embed:tomcat-embed-jasper:8.0.41") |
There was a problem hiding this comment.
In my opinion this comment isn't relevant. It was previously using 9+ for both regular build and latest deps which is bad because it is really confusing when regular build starts failing without any code changes. 8.0.41 is the version used in servlet-3.0 tests. I didn't try to figure out whether this is really the earliest version that works, only checked that 8.0.1 didn't work. The part of version 10 is kind of obvious, servlet-3.0 uses the same construct and doesn't have a comment. Jasper dependency was added to get rid of a non fatal stack trace in test output.
|
btw thanks for finding/fixing, this was quite confusing failure 👍 |
In tomcat 9.0.52 async servlet tests don't pass without instrumenting
org.apache.tomcat.util.threads.ThreadPoolExecutor