Add HttpClientTestOptions #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
iNikem
approved these changes
Jul 29, 2021
trask
approved these changes
Jul 29, 2021
| import org.junit.jupiter.api.condition.DisabledIfSystemProperty; | ||
| import org.junit.jupiter.params.ParameterizedTest; | ||
| import org.junit.jupiter.params.provider.ValueSource; | ||
|
|
||
| @TestInstance(TestInstance.Lifecycle.PER_CLASS) |
There was a problem hiding this comment.
will this affect subclasses? will that be less obvious compared to making options below static?
There was a problem hiding this comment.
This is a good question, I'll confirm it but I would expect it to, most jupiter functionality goes through hierarchy. I don't think I can use the subclass configure pattern (or any pattern I can think of) if static, especially because the @BeforeAll method must be static if this isn't here.
There was a problem hiding this comment.
Confirmed that it's respected by subclasses. Though I did come with another pattern using an extension, will play with it in a followup (if I can ever merge past the GwtTest failure :P)
added 4 commits
July 30, 2021 13:23
…nstrumentation into httpclienttestoptions
…nstrumentation into httpclienttestoptions
…nstrumentation into httpclienttestoptions
…nstrumentation into httpclienttestoptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have many protected methods to tweak test behavior, but it can be hard to understand what options we have or what the defaults are. I think having all options grouped makes it easier to understand how to configure the test - a big reason for this is to simplify the spock bridge.
I just copied the options as is for now, but I think we can iterate to improve more - I find the knobs now to be confusing on what they control, some are semantic and control multiple tests, many just control a single test, some have different names then the test itself, etc. I also really don't like how many subclasses use the URL 192.0.2.3 as a proxy for what test they are running on to reconfigure the test. So I have some ideas about maybe having an enum corresponding to each test, or similar which will follow up with eventually.
Also if this approach looks fine, will follow up with a PR to migrate the remaining tests.